Messages in this thread | | | Date | Thu, 31 Mar 2022 19:26:30 -0300 | From | Jason Gunthorpe <> | Subject | Re: [PATCH RFC v2 08/11] iommu/sva: Use attach/detach_pasid_dev in SVA interfaces |
| |
On Thu, Mar 31, 2022 at 01:59:22PM -0700, Jacob Pan wrote:
> > + handle->dev = dev; > > + handle->domain = domain; > > + handle->pasid = mm->pasid;
> why do we need to store pasid here? Conceptually, pasid is per sva domain > not per bind. You can get it from handle->domain->sva_cookie.
That is a mistake - SVA needs to follow the general PASID design - the domain does not encode the PASID, the PASID comes from the device attachment only.
Jason
| |