Messages in this thread | | | Date | Mon, 4 Apr 2022 13:55:25 +0800 | Subject | Re: [PATCH RFC v2 08/11] iommu/sva: Use attach/detach_pasid_dev in SVA interfaces | From | Lu Baolu <> |
| |
On 2022/4/1 6:26, Jason Gunthorpe wrote: > On Thu, Mar 31, 2022 at 01:59:22PM -0700, Jacob Pan wrote: > >>> + handle->dev = dev; >>> + handle->domain = domain; >>> + handle->pasid = mm->pasid; >> why do we need to store pasid here? Conceptually, pasid is per sva domain >> not per bind. You can get it from handle->domain->sva_cookie. > That is a mistake - SVA needs to follow the general PASID design - the > domain does not encode the PASID, the PASID comes from the device
You are right. We should not store any pasid information in the domain.
Best regards, baolu
| |