Messages in this thread | | | Date | Tue, 29 Mar 2022 19:42:00 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 09/13] pinctrl: meson: Rename REG_* to MREG_* |
| |
On Tue, Mar 29, 2022 at 06:13:19PM +0200, Neil Armstrong wrote: > On 29/03/2022 17:29, Andy Shevchenko wrote: > > Rename REG_* to * as a prerequisite for enabling COMPILE_TEST. > > What error do you hit ?
arch/x86/include/asm/arch_hweight.h:9:17: error: expected identifier before string constant 9 | #define REG_OUT "a" | ^~~ drivers/pinctrl/meson/pinctrl-meson.h:69:9: note: in expansion of macro ‘REG_OUT’ 69 | REG_OUT,
And some more.
> MREG_ is rather ugly, something like PINCONF_REG_ or more simpler MESON_REG_ would be more appropriate.
Fine with me.
-- With Best Regards, Andy Shevchenko
| |