lkml.org 
[lkml]   [2022]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 09/13] pinctrl: meson: Rename REG_* to MREG_*
From
On 29/03/2022 17:29, Andy Shevchenko wrote:
> Rename REG_* to MREG_* as a prerequisite for enabling COMPILE_TEST.

What error do you hit ?

MREG_ is rather ugly, something like PINCONF_REG_ or more simpler MESON_REG_ would be more appropriate.

Neil

>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/pinctrl/meson/pinctrl-meson.c | 24 ++++++++++++------------
> drivers/pinctrl/meson/pinctrl-meson.h | 24 ++++++++++++------------
> 2 files changed, 24 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/pinctrl/meson/pinctrl-meson.c b/drivers/pinctrl/meson/pinctrl-meson.c
> index 49851444a6e3..64da61ba2bb9 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson.c
> @@ -218,13 +218,13 @@ static int meson_pinconf_set_output(struct meson_pinctrl *pc,
> unsigned int pin,
> bool out)
> {
> - return meson_pinconf_set_gpio_bit(pc, pin, REG_DIR, !out);
> + return meson_pinconf_set_gpio_bit(pc, pin, MREG_DIR, !out);
> }
>
> static int meson_pinconf_get_output(struct meson_pinctrl *pc,
> unsigned int pin)
> {
> - int ret = meson_pinconf_get_gpio_bit(pc, pin, REG_DIR);
> + int ret = meson_pinconf_get_gpio_bit(pc, pin, MREG_DIR);
>
> if (ret < 0)
> return ret;
> @@ -236,13 +236,13 @@ static int meson_pinconf_set_drive(struct meson_pinctrl *pc,
> unsigned int pin,
> bool high)
> {
> - return meson_pinconf_set_gpio_bit(pc, pin, REG_OUT, high);
> + return meson_pinconf_set_gpio_bit(pc, pin, MREG_OUT, high);
> }
>
> static int meson_pinconf_get_drive(struct meson_pinctrl *pc,
> unsigned int pin)
> {
> - return meson_pinconf_get_gpio_bit(pc, pin, REG_OUT);
> + return meson_pinconf_get_gpio_bit(pc, pin, MREG_OUT);
> }
>
> static int meson_pinconf_set_output_drive(struct meson_pinctrl *pc,
> @@ -269,7 +269,7 @@ static int meson_pinconf_disable_bias(struct meson_pinctrl *pc,
> if (ret)
> return ret;
>
> - meson_calc_reg_and_bit(bank, pin, REG_PULLEN, &reg, &bit);
> + meson_calc_reg_and_bit(bank, pin, MREG_PULLEN, &reg, &bit);
> ret = regmap_update_bits(pc->reg_pullen, reg, BIT(bit), 0);
> if (ret)
> return ret;
> @@ -288,7 +288,7 @@ static int meson_pinconf_enable_bias(struct meson_pinctrl *pc, unsigned int pin,
> if (ret)
> return ret;
>
> - meson_calc_reg_and_bit(bank, pin, REG_PULL, &reg, &bit);
> + meson_calc_reg_and_bit(bank, pin, MREG_PULL, &reg, &bit);
> if (pull_up)
> val = BIT(bit);
>
> @@ -296,7 +296,7 @@ static int meson_pinconf_enable_bias(struct meson_pinctrl *pc, unsigned int pin,
> if (ret)
> return ret;
>
> - meson_calc_reg_and_bit(bank, pin, REG_PULLEN, &reg, &bit);
> + meson_calc_reg_and_bit(bank, pin, MREG_PULLEN, &reg, &bit);
> ret = regmap_update_bits(pc->reg_pullen, reg, BIT(bit), BIT(bit));
> if (ret)
> return ret;
> @@ -321,7 +321,7 @@ static int meson_pinconf_set_drive_strength(struct meson_pinctrl *pc,
> if (ret)
> return ret;
>
> - meson_calc_reg_and_bit(bank, pin, REG_DS, &reg, &bit);
> + meson_calc_reg_and_bit(bank, pin, MREG_DS, &reg, &bit);
>
> if (drive_strength_ua <= 500) {
> ds_val = MESON_PINCONF_DRV_500UA;
> @@ -407,7 +407,7 @@ static int meson_pinconf_get_pull(struct meson_pinctrl *pc, unsigned int pin)
> if (ret)
> return ret;
>
> - meson_calc_reg_and_bit(bank, pin, REG_PULLEN, &reg, &bit);
> + meson_calc_reg_and_bit(bank, pin, MREG_PULLEN, &reg, &bit);
>
> ret = regmap_read(pc->reg_pullen, reg, &val);
> if (ret)
> @@ -416,7 +416,7 @@ static int meson_pinconf_get_pull(struct meson_pinctrl *pc, unsigned int pin)
> if (!(val & BIT(bit))) {
> conf = PIN_CONFIG_BIAS_DISABLE;
> } else {
> - meson_calc_reg_and_bit(bank, pin, REG_PULL, &reg, &bit);
> + meson_calc_reg_and_bit(bank, pin, MREG_PULL, &reg, &bit);
>
> ret = regmap_read(pc->reg_pull, reg, &val);
> if (ret)
> @@ -447,7 +447,7 @@ static int meson_pinconf_get_drive_strength(struct meson_pinctrl *pc,
> if (ret)
> return ret;
>
> - meson_calc_reg_and_bit(bank, pin, REG_DS, &reg, &bit);
> + meson_calc_reg_and_bit(bank, pin, MREG_DS, &reg, &bit);
>
> ret = regmap_read(pc->reg_ds, reg, &val);
> if (ret)
> @@ -595,7 +595,7 @@ static int meson_gpio_get(struct gpio_chip *chip, unsigned gpio)
> if (ret)
> return ret;
>
> - meson_calc_reg_and_bit(bank, gpio, REG_IN, &reg, &bit);
> + meson_calc_reg_and_bit(bank, gpio, MREG_IN, &reg, &bit);
> regmap_read(pc->reg_gpio, reg, &val);
>
> return !!(val & BIT(bit));
> diff --git a/drivers/pinctrl/meson/pinctrl-meson.h b/drivers/pinctrl/meson/pinctrl-meson.h
> index ff5372e0a475..c00d9ad27843 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson.h
> +++ b/drivers/pinctrl/meson/pinctrl-meson.h
> @@ -63,12 +63,12 @@ struct meson_reg_desc {
> * enum meson_reg_type - type of registers encoded in @meson_reg_desc
> */
> enum meson_reg_type {
> - REG_PULLEN,
> - REG_PULL,
> - REG_DIR,
> - REG_OUT,
> - REG_IN,
> - REG_DS,
> + MREG_PULLEN,
> + MREG_PULL,
> + MREG_DIR,
> + MREG_OUT,
> + MREG_IN,
> + MREG_DS,
> NUM_REG,
> };
>
> @@ -150,12 +150,12 @@ struct meson_pinctrl {
> .irq_first = fi, \
> .irq_last = li, \
> .regs = { \
> - [REG_PULLEN] = { per, peb }, \
> - [REG_PULL] = { pr, pb }, \
> - [REG_DIR] = { dr, db }, \
> - [REG_OUT] = { or, ob }, \
> - [REG_IN] = { ir, ib }, \
> - [REG_DS] = { dsr, dsb }, \
> + [MREG_PULLEN] = { per, peb }, \
> + [MREG_PULL] = { pr, pb }, \
> + [MREG_DIR] = { dr, db }, \
> + [MREG_OUT] = { or, ob }, \
> + [MREG_IN] = { ir, ib }, \
> + [MREG_DS] = { dsr, dsb }, \
> }, \
> }
>

\
 
 \ /
  Last update: 2022-03-29 18:14    [W:0.161 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site