| Date | Tue, 29 Mar 2022 17:17:01 +0200 | From | Sebastian Fricke <> | Subject | Re: [PATCH v1 13/24] media: rkvdec: h264: Fix reference frame_num wrap for second field |
| |
Hey Nicolas,
On 28.03.2022 15:59, Nicolas Dufresne wrote: >From: Jonas Karlman <jonas@kwiboo.se> > >When decoding the second field in a complementary field pair the second >field is sharing the same frame_num with the first field. > >Currently the frame_num for the first field is wrapped when it matches the >field being decoded, this cause issues to decode the second field in a >complementary field pair. > >Fix this by using inclusive comparison, less than or equal. > >Signed-off-by: Jonas Karlman <jonas@kwiboo.se> >Reviewed-by: Ezequiel Garcia <ezequiel@collabora.com> Reviewed-by: Sebastian Fricke <sebastian.fricke@collabora.com>
Greetings, Sebastian
>--- > drivers/staging/media/rkvdec/rkvdec-h264.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/staging/media/rkvdec/rkvdec-h264.c b/drivers/staging/media/rkvdec/rkvdec-h264.c >index dff89732ddd0..842d8cd80e90 100644 >--- a/drivers/staging/media/rkvdec/rkvdec-h264.c >+++ b/drivers/staging/media/rkvdec/rkvdec-h264.c >@@ -752,7 +752,7 @@ static void assemble_hw_rps(struct rkvdec_ctx *ctx, > continue; > > if (dpb[i].flags & V4L2_H264_DPB_ENTRY_FLAG_LONG_TERM || >- dpb[i].frame_num < dec_params->frame_num) { >+ dpb[i].frame_num <= dec_params->frame_num) { > p[i] = dpb[i].frame_num; > continue; > } >-- >2.34.1 >
|