Messages in this thread | | | Date | Tue, 29 Mar 2022 17:34:19 +0200 | From | Sebastian Fricke <> | Subject | Re: [PATCH v1 15/24] media: rkvdec: Enable capture buffer holding for H264 |
| |
Hey Nicolas,
On 28.03.2022 15:59, Nicolas Dufresne wrote: >In order to support interlaced video decoding, the driver must >allow holding the capture buffer so that the second field can >be decoded into it. > >Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> Reviewed-by: Sebastian Fricke <sebastian.fricke@collabora.com>
>--- > drivers/staging/media/rkvdec/rkvdec.c | 4 ++++ > drivers/staging/media/rkvdec/rkvdec.h | 1 + > 2 files changed, 5 insertions(+) > >diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c >index 2df8cf4883e2..05824f1997f7 100644 >--- a/drivers/staging/media/rkvdec/rkvdec.c >+++ b/drivers/staging/media/rkvdec/rkvdec.c >@@ -138,6 +138,7 @@ static const struct rkvdec_coded_fmt_desc rkvdec_coded_fmts[] = { > .ops = &rkvdec_h264_fmt_ops, > .num_decoded_fmts = ARRAY_SIZE(rkvdec_h264_vp9_decoded_fmts), > .decoded_fmts = rkvdec_h264_vp9_decoded_fmts, >+ .subsystem_flags = VB2_V4L2_FL_SUPPORTS_M2M_HOLD_CAPTURE_BUF, > }, > { > .fourcc = V4L2_PIX_FMT_VP9_FRAME, >@@ -394,6 +395,9 @@ static int rkvdec_s_output_fmt(struct file *file, void *priv, > cap_fmt->fmt.pix_mp.ycbcr_enc = f->fmt.pix_mp.ycbcr_enc; > cap_fmt->fmt.pix_mp.quantization = f->fmt.pix_mp.quantization; > >+ /* Enable format specific queue feature */
s/feature/features/
Greetings, Sebastian
>+ vq->subsystem_flags |= desc->subsystem_flags; >+ > return 0; > } > >diff --git a/drivers/staging/media/rkvdec/rkvdec.h b/drivers/staging/media/rkvdec/rkvdec.h >index 2f4ea1786b93..e37f1a015fa0 100644 >--- a/drivers/staging/media/rkvdec/rkvdec.h >+++ b/drivers/staging/media/rkvdec/rkvdec.h >@@ -81,6 +81,7 @@ struct rkvdec_coded_fmt_desc { > const struct rkvdec_coded_fmt_ops *ops; > unsigned int num_decoded_fmts; > const u32 *decoded_fmts; >+ u32 subsystem_flags; > }; > > struct rkvdec_dev { >-- >2.34.1 >
| |