lkml.org 
[lkml]   [2022]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] fs: fix -Wmissing-declaration warning
Date
I encontered the following warning when compiling with
-Wmissing-declarations:

fs/namei.c:2587:5: warning: no previous declaration for
‘filename_parentat’ [-Wmissing-declarations]
2587 | int filename_parentat(int dfd, struct filename *name, unsigned
int flags,
| ^~~~~~~~~~~~~~~~~)

This warning was introduced by recent commit 43ff44bde7e5 ("ksmbd: fix
racy issue from using ->d_parent and ->d_name").

Address this warning by declaring the function as static, setting its
scope to the containing file.

Signed-off-by: Enze Li <lienze@kylinos.cn>
---
fs/namei.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/namei.c b/fs/namei.c
index 44c366f3152f..fe3525807361 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -2584,7 +2584,7 @@ static int __filename_parentat(int dfd, struct filename *name,
return retval;
}

-int filename_parentat(int dfd, struct filename *name, unsigned int flags,
+static int filename_parentat(int dfd, struct filename *name, unsigned int flags,
struct path *parent, struct qstr *last, int *type)
{
return __filename_parentat(dfd, name, flags, parent, last, type, NULL);
--
2.25.1
\
 
 \ /
  Last update: 2022-03-23 11:02    [W:0.019 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site