lkml.org 
[lkml]   [2022]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tools/vm/page_owner_sort.c: add switch between culling by stacktrace and txt
On Tue, 22 Mar 2022 10:22:05 +0800 Yinan Zhang <zhangyinan2019@email.szu.edu.cn> wrote:

> on 2022/3/22 4:38, Andrew Morton wrote:
>
> > These comments were not responded to:
> >
> > On Mon, 29 Nov 2021 21:23:41 -0500 Sean Anderson<seanga2@gmail.com> wrote:
> >> This is working as designed. IMO there's no point in separating
> >> allocations like this which differ only in PID and timestamp, since you
> >> will get no grouping at all.
> >>
> >>> The info of second block missed. So, add -c to turn on culling
> >>> by stacktrace. By default, it will cull by txt.
> >> Please keep the default to actually do something in the cull step.
> >>
> >> ...
> >>
> >>> @@ -162,6 +171,9 @@ int main(int argc, char **argv)
> >>> case 't':
> >>> cmp = compare_num;
> >>> break;
> >>> + case 'c':
> >>> + cull_st = 1;
> >>> + break;
> >> Can we set a "cull_cmp" variable like cmp?
> >>
> >> Looking forward, I think something like
> >>
> >> page_owner_sort --cull=stacktrace --sort=times foo bar
> >>
> >> would be nice.
> >>
> > Which is unfortunate.
> >
> > I'll send the patch in to Linus anyway, as many other patches
> > syntactically depend on it. Please work with Sean to address these
> > issues and lets get this resolved over the next few weeks.
> >
> > Also, please cclinux-mm@kvack.org on changes to page_owner.
> >

(top-posting repaired)

> I replied to the email a few months ago. Did you receive it?

I didn't, and it isn't in the list archives at

https://lore.kernel.org/all/20211129145658.2491-1-zhangyinan2019@email.szu.edu.cn/T/#u

\
 
 \ /
  Last update: 2022-03-22 19:02    [W:0.093 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site