Messages in this thread | | | Subject | Re: [PATCH] tools/vm/page_owner_sort.c: add switch between culling by stacktrace and txt | From | Sean Anderson <> | Date | Mon, 21 Mar 2022 23:55:29 -0400 |
| |
On 3/21/22 10:22 PM, Yinan Zhang wrote: > I replied to the email a few months ago. Did you receive it?
The patch was applied anyway. Anything in this subsystem gets applied within a day or two regardless of feedback. Personally, I'm not motivated to review anything because of that.
--Sean
> > on 2022/3/22 4:38, Andrew Morton wrote: > >> These comments were not responded to: >> >> On Mon, 29 Nov 2021 21:23:41 -0500 Sean Anderson<seanga2@gmail.com> wrote: >>> This is working as designed. IMO there's no point in separating >>> allocations like this which differ only in PID and timestamp, since you >>> will get no grouping at all. >>> >>>> The info of second block missed. So, add -c to turn on culling >>>> by stacktrace. By default, it will cull by txt. >>> Please keep the default to actually do something in the cull step. >>> >>> ... >>> >>>> @@ -162,6 +171,9 @@ int main(int argc, char **argv) >>>> case 't': >>>> cmp = compare_num; >>>> break; >>>> + case 'c': >>>> + cull_st = 1; >>>> + break; >>> Can we set a "cull_cmp" variable like cmp? >>> >>> Looking forward, I think something like >>> >>> page_owner_sort --cull=stacktrace --sort=times foo bar >>> >>> would be nice. >>> >> Which is unfortunate. >> >> I'll send the patch in to Linus anyway, as many other patches >> syntactically depend on it. Please work with Sean to address these >> issues and lets get this resolved over the next few weeks. >> >> Also, please cclinux-mm@kvack.org on changes to page_owner. >>
| |