Messages in this thread | | | Date | Thu, 3 Mar 2022 03:25:09 +0100 | From | Andrew Lunn <> | Subject | Re: [net-next PATCH v2] net: dsa: qca8k: pack driver struct and improve cache use |
| |
On Thu, Mar 03, 2022 at 03:53:27AM +0200, Vladimir Oltean wrote: > On Mon, Feb 28, 2022 at 12:04:08PM +0100, Ansuel Smith wrote: > > Pack qca8k priv and other struct using pahole and set the first priv > > struct entry to mgmt_master and mgmt_eth_data to speedup access. > > While at it also rework pcs struct and move it qca8k_ports_config > > following other configuration set for the cpu ports. > > > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> > > --- > > How did you "pack" struct qca8k_priv exactly?
As far as i can see, nothing in qca8k_priv is on the hot path. So i doubt anything changed here will make a difference. The MDIO bus is the bottleneck, not the memory interface.
Andrew
| |