Messages in this thread | | | Date | Thu, 17 Mar 2022 11:12:45 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH] gpiolib: acpi: use correct format characters |
| |
On Thu, Mar 17, 2022 at 11:06:51AM +0200, Andy Shevchenko wrote: > On Wed, Mar 16, 2022 at 02:30:55PM -0700, Bill Wendling wrote: > > When compiling with -Wformat, clang emits the following warning: > > > > drivers/gpio/gpiolib-acpi.c:393:4: warning: format specifies type > > 'unsigned char' but the argument has type 'int' [-Wformat] > > pin); > > ^~~ > > > > The types of these arguments are unconditionally defined, so this patch > > updates the format character to the correct ones for ints and unsigned > > ints. > > hhX specifier refers to unsigned char. It's a bug in the compiler. > > NAK.
Oh, I read this wrong, sorry. The pin has been checked to fit in one byte, but its type is bigger indeed.
I will apply your patch right away and send as a fix after rc1.
-- With Best Regards, Andy Shevchenko
| |