Messages in this thread | | | From | Bill Wendling <> | Date | Fri, 18 Mar 2022 11:25:25 -0700 | Subject | Re: [PATCH] gpiolib: acpi: use correct format characters |
| |
On Fri, Mar 18, 2022 at 11:01 AM Nick Desaulniers <ndesaulniers@google.com> wrote: > > On Fri, Mar 18, 2022 at 7:04 AM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > > On Thu, Mar 17, 2022 at 11:11:21AM -0700, Nick Desaulniers wrote: > > > Our goal is to enable -Wformat for CC=clang. Please see also: > > > commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of > > > unnecessary %h[xudi] and %hh[xudi]") > > > > Not that I agree on that commit for %h[h]x > > > > signed char ch = -1; > > printf("%x\n", ch); > > printf("%hhx\n", ch); > > Will print: > ffffffff > ff > I noticed this. My first thought was to do something akin to:
printf("%x\n", (u8)ch);
but went the route of removing the "h" qualifiers to be more in line with previous fixes. I will be happy to change this patch if that's what you would prefer.
-bw
| |