Messages in this thread Patch in this message | | | From | Haowen Bai <> | Subject | [PATCH] firmware: edd: Remove redundant condition | Date | Thu, 17 Mar 2022 18:05:20 +0800 |
| |
The logic !A || A && B is equivalent to !A || B. so we have to make code clear.
Signed-off-by: Haowen Bai <baihaowen@meizu.com> --- drivers/firmware/edd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/firmware/edd.c b/drivers/firmware/edd.c index 69353dd..5cc2389 100644 --- a/drivers/firmware/edd.c +++ b/drivers/firmware/edd.c @@ -685,8 +685,7 @@ static void edd_populate_dir(struct edd_device * edev) int i; for (i = 0; (attr = edd_attrs[i]) && !error; i++) { - if (!attr->test || - (attr->test && attr->test(edev))) + if (!attr->test || attr->test(edev)) error = sysfs_create_file(&edev->kobj,&attr->attr); } -- 2.7.4
| |