lkml.org 
[lkml]   [2022]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subject[PATCH 0/3 RESEND] platform/x86, apcica: Sanitize EBDA pointer from memory
[Resend because I messed up the mailing list addresses]

When testing custom virtualization platform, we noticed that in cases
where the memory is initialized with random pattern, the Linux guest
tends to crash on EPT violation.

It turns out that (at least two) codepaths during boot do not check the
validity of EBDA pointer retrieved from BDA memory at address 0x40e.
In case that the returned address is over 640K, the kernel happily
touches the VGA memory (which was not present in our setup, hence the
EPT violation).

This may be problematic in other virtualized environment too, but it can
probably also happen on bare metal when booted with legacy free (e.g.
UEFI without CSM) firmware, because the BDA may not be initialized and
the VGA range might not be properly decoded.

The third patch of the series adds workaround for the situation where
EBDA is smaller than 1KiB and the ACPI code scanning for RSDP table
bumps to the VGA memory.

The two acpcia patches can eventually be squashed together, it's up to you.

I tested these patches on my lenovo laptop (and in QEMU if that counts).

Vit Kabele (3):
platform/x86: Check validity of EBDA pointer in mpparse.c
acpica: Check that the EBDA pointer is in valid range
acpica: Do not touch VGA memory when EBDA < 1KiB

arch/x86/include/asm/bios_ebda.h | 3 +++
arch/x86/kernel/ebda.c | 3 ---
arch/x86/kernel/mpparse.c | 12 +++++++++++-
drivers/acpi/acpica/tbxfroot.c | 25 ++++++++++++++++++-------
4 files changed, 32 insertions(+), 11 deletions(-)

--
2.30.2

\
 
 \ /
  Last update: 2022-03-17 19:56    [W:0.028 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site