Messages in this thread Patch in this message | | | From | Miaohe Lin <> | Subject | [PATCH] mm/swap: simplify the code of find_get_incore_page() | Date | Wed, 16 Mar 2022 15:59:41 +0800 |
| |
pagecache_get_page() can return subpage for us if we do not specify FGP_HEAD. No functional change intended.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> --- mm/swap_state.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/mm/swap_state.c b/mm/swap_state.c index ee67164531c0..517b4b856e32 100644 --- a/mm/swap_state.c +++ b/mm/swap_state.c @@ -394,13 +394,10 @@ struct page *find_get_incore_page(struct address_space *mapping, pgoff_t index) { swp_entry_t swp; struct swap_info_struct *si; - struct page *page = pagecache_get_page(mapping, index, - FGP_ENTRY | FGP_HEAD, 0); + struct page *page = pagecache_get_page(mapping, index, FGP_ENTRY, 0); - if (!page) + if (!page || !xa_is_value(page)) return page; - if (!xa_is_value(page)) - return find_subpage(page, index); if (!shmem_mapping(mapping)) return NULL; -- 2.23.0
| |