Messages in this thread Patch in this message | | | From | xkernel.wang@foxmail ... | Subject | [PATCH v2] ASoC: samsung: i2s: check the return value of kstrdup() | Date | Mon, 14 Mar 2022 18:36:45 +0800 |
| |
From: Xiaoke Wang <xkernel.wang@foxmail.com>
kstrdup() is a memory allocation function which can return NULL when some internal memory errors happen. It is better to check the return value of it to catch the error in time.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com> --- ChangeLog: v1->v2 update the mail list and attach the tag 'Reviewed-by'. sound/soc/samsung/i2s.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c index 309badc..70c8271 100644 --- a/sound/soc/samsung/i2s.c +++ b/sound/soc/samsung/i2s.c @@ -1349,6 +1349,10 @@ static int i2s_create_secondary_device(struct samsung_i2s_priv *priv) return -ENOMEM; pdev_sec->driver_override = kstrdup("samsung-i2s", GFP_KERNEL); + if (!pdev_sec->driver_override) { + platform_device_put(pdev_sec); + return -ENOMEM; + } ret = platform_device_add(pdev_sec); if (ret < 0) { --
| |