Messages in this thread | | | From | Masahiro Yamada <> | Date | Mon, 14 Mar 2022 01:35:04 +0900 | Subject | Re: [PATCH] ARM: decompressor: do not copy source files while building |
| |
On Fri, Mar 11, 2022 at 9:07 PM Russell King (Oracle) <linux@armlinux.org.uk> wrote: > > On Sun, Oct 31, 2021 at 02:52:58AM +0900, Masahiro Yamada wrote: > > As commit 7ae4a78daacf ("ARM: 8969/1: decompressor: simplify libfdt > > builds") stated, copying source files during the build time may not > > end up with as clean code as expected. > > > > Do similar for the other library files for further cleanups of the > > Makefile and .gitignore. > > > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > > Hi, > > I am now seeing the following every time I run a build: > > GEN Makefile > CALL .../linux-rmk/scripts/atomic/check-atomics.sh > CALL .../linux-rmk/scripts/checksyscalls.sh > CHK include/generated/compile.h > Kernel: arch/arm/boot/Image is ready > AS arch/arm/boot/compressed/lib1funcs.o > AS arch/arm/boot/compressed/ashldi3.o > AS arch/arm/boot/compressed/bswapsdi2.o > LD arch/arm/boot/compressed/vmlinux > OBJCOPY arch/arm/boot/zImage > Kernel: arch/arm/boot/zImage is ready > > In other words, those three objects are always rebuilt even though > they haven't changed. > > I've tried removing the arch/arm/boot/compressed directory in the > build tree, but that doesn't make any difference. > > Running with V=2 shows: > > AS arch/arm/boot/compressed/lib1funcs.o - due to lib1funcs.o not in $(tar > gets) > AS arch/arm/boot/compressed/ashldi3.o - due to ashldi3.o not in $(targets) > AS arch/arm/boot/compressed/bswapsdi2.o - due to bswapsdi2.o not in $(targets) > > It looks to me like: > OBJS += lib1funcs.o ashldi3.o bswapsdi2.o > > in your patch should have been added before: > > targets := vmlinux vmlinux.lds piggy_data piggy.o \ > head.o $(OBJS) > > Please confirm.
Sorry for my late reply.
Yes, you are right.
OBJS += lib1funcs.o ashldi3.o bswapsdi2.o
should come before the 'targets' assignment.
-- Best Regards Masahiro Yamada
| |