Messages in this thread | | | Date | Wed, 30 Mar 2022 17:22:33 +0100 | From | "Russell King (Oracle)" <> | Subject | Re: [PATCH] ARM: decompressor: do not copy source files while building |
| |
Hi,
Your reply was too late for me, I've been away on vacation from 14th March until now... and now I've got a whole truck-load of catch-up, so it's likely I'll forget to sort this. Please send a patch to fix it, thanks.
On Fri, Mar 25, 2022 at 11:54:07AM +0900, Masahiro Yamada wrote: > Hi Russell, > > > Was this issue fixed? > (I see nothing happened in linux-next yet) > > I will not send a patch because I assume you will > fix this by yourself. If there is something you want > me, please let me know. > > Thanks. > Masahiro Yamada > > > > > > > On Mon, Mar 14, 2022 at 1:35 AM Masahiro Yamada <masahiroy@kernel.org> wrote: > > > > On Fri, Mar 11, 2022 at 9:07 PM Russell King (Oracle) > > <linux@armlinux.org.uk> wrote: > > > > > > On Sun, Oct 31, 2021 at 02:52:58AM +0900, Masahiro Yamada wrote: > > > > As commit 7ae4a78daacf ("ARM: 8969/1: decompressor: simplify libfdt > > > > builds") stated, copying source files during the build time may not > > > > end up with as clean code as expected. > > > > > > > > Do similar for the other library files for further cleanups of the > > > > Makefile and .gitignore. > > > > > > > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > > > > > > Hi, > > > > > > I am now seeing the following every time I run a build: > > > > > > GEN Makefile > > > CALL .../linux-rmk/scripts/atomic/check-atomics.sh > > > CALL .../linux-rmk/scripts/checksyscalls.sh > > > CHK include/generated/compile.h > > > Kernel: arch/arm/boot/Image is ready > > > AS arch/arm/boot/compressed/lib1funcs.o > > > AS arch/arm/boot/compressed/ashldi3.o > > > AS arch/arm/boot/compressed/bswapsdi2.o > > > LD arch/arm/boot/compressed/vmlinux > > > OBJCOPY arch/arm/boot/zImage > > > Kernel: arch/arm/boot/zImage is ready > > > > > > In other words, those three objects are always rebuilt even though > > > they haven't changed. > > > > > > I've tried removing the arch/arm/boot/compressed directory in the > > > build tree, but that doesn't make any difference. > > > > > > Running with V=2 shows: > > > > > > AS arch/arm/boot/compressed/lib1funcs.o - due to lib1funcs.o not in $(tar > > > gets) > > > AS arch/arm/boot/compressed/ashldi3.o - due to ashldi3.o not in $(targets) > > > AS arch/arm/boot/compressed/bswapsdi2.o - due to bswapsdi2.o not in $(targets) > > > > > > It looks to me like: > > > OBJS += lib1funcs.o ashldi3.o bswapsdi2.o > > > > > > in your patch should have been added before: > > > > > > targets := vmlinux vmlinux.lds piggy_data piggy.o \ > > > head.o $(OBJS) > > > > > > Please confirm. > > > > > > Sorry for my late reply. > > > > Yes, you are right. > > > > OBJS += lib1funcs.o ashldi3.o bswapsdi2.o > > > > should come before the 'targets' assignment. > > > > > > > > > > > > -- > > Best Regards > > Masahiro Yamada > > > > -- > Best Regards > Masahiro Yamada >
-- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
| |