Messages in this thread Patch in this message | | | From | Weiguo Li <> | Subject | [PATCH] perf parse-events: Fix null check | Date | Fri, 11 Mar 2022 21:06:57 +0800 |
| |
We did a null check after "tmp->symbol = strdup(...)", but we checked "list->symbol" other than "tmp->symbol".
Signed-off-by: Weiguo Li <liwg06@foxmail.com> --- tools/perf/util/parse-events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c index 9739b05b999e..dfb50a5f83d0 100644 --- a/tools/perf/util/parse-events.c +++ b/tools/perf/util/parse-events.c @@ -2193,7 +2193,7 @@ int perf_pmu__test_parse_init(void) for (i = 0; i < ARRAY_SIZE(symbols); i++, tmp++) { tmp->type = symbols[i].type; tmp->symbol = strdup(symbols[i].symbol); - if (!list->symbol) + if (!tmp->symbol) goto err_free; } -- 2.25.1
| |