lkml.org 
[lkml]   [2022]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 0/4] Introduce "opp-microwatt" and Energy Model from DT
On 01-03-22, 09:35, Lukasz Luba wrote:
> Hi all,
>
> This patch set solves a few issues:
> 1. It allows to register EM from DT, when the voltage information is not
> available. (Some background of the issues present on Chromebook devices
> can be checked at [1].)
> 2. It allows to register 'advanced' EM from the DT, which is more accurate
> and reflects total power (dynamic + static).
>
> Implementation details:
> Existing machinery in the OPP framework now handles "opp-microwatt", similarly
> to "opp-microamp". It also has helper exported function to get power from OPP.
> For the EM, it adds a new callback in OPP framework to use this new API and
> read power while having an opp pointer. It's agreed to work with OPP-v2.
>
> Comments, suggestions are very welcome.
>
> changelog:
> v4:
> - changed calculation of power, summing add all supliers power for an opp
> - added opp debugfs for u_watt
> - added patternProperties in dt-bindings for this new opp-microwatt
> - changed the EM opp registration flow and used one EM api registration call
> - changed name of _get_opp_power() to _get_dt_power()
> - removed 'advanced' word from the new paragraph and content in EM doc changes
> v3 [2]

Apart from one minor things, the patchset looks fine now. Thanks for
considering the review comments :)

--
viresh

\
 
 \ /
  Last update: 2022-03-02 05:54    [W:0.094 / U:1.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site