Messages in this thread | | | From | Bhupesh Sharma <> | Date | Wed, 2 Mar 2022 02:03:27 +0530 | Subject | Re: [PATCH 5/8] arm64: dts: qcom: sa8155p-adp: Enable ethernet node |
| |
Hi Andrew,
Sorry for the late reply.
On Thu, 27 Jan 2022 at 05:37, Andrew Lunn <andrew@lunn.ch> wrote: > > > +ðernet { > > + status = "okay"; > > + > > + snps,reset-gpio = <&tlmm 79 GPIO_ACTIVE_LOW>; > > + snps,reset-active-low; > > + snps,reset-delays-us = <0 11000 70000>; > > + > > + snps,ptp-ref-clk-rate = <250000000>; > > + snps,ptp-req-clk-rate = <96000000>; > > + > > + snps,mtl-rx-config = <&mtl_rx_setup>; > > + snps,mtl-tx-config = <&mtl_tx_setup>; > > + > > + pinctrl-names = "default"; > > + pinctrl-0 = <ðernet_defaults>; > > + > > + phy-handle = <&rgmii_phy>; > > + phy-mode = "rgmii"; > > Where are the rgmii delays being added for this board?
I am not sure if I am missing something, but I don't see any rgmii tx or rx delay dts properties for the dwmac-qcom-ethqos driver (see [1] and [2]).
I see that some stmmac drivers (for e.g. drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c), do define and use dts properties that define the delays (for e.g. 'allwinner,tx-delay-ps'), but I cannot find something equivalent for 'dwmac-qcom-ethqos.c'.
[1]. Documentation/devicetree/bindings/net/qcom,ethqos.txt [2]. Documentation/devicetree/bindings/net/snps,dwmac.yaml
Regards, Bhupesh
| |