| Date | Wed, 9 Feb 2022 17:15:41 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v3 4/7] drm/solomon: Add SSD130X OLED displays I2C support |
| |
On Wed, Feb 09, 2022 at 10:03:11AM +0100, Javier Martinez Canillas wrote: > The ssd130x driver only provides the core support for these devices but it > does not have any bus transport logic. Add a driver to interface over I2C.
Thanks!
...
> + * Authors: Javier Martinez Canillas <javierm@redhat.com>
s?!
...
> +#include <linux/i2c.h> > +#include <linux/module.h>
regmap.h ? err.h?
...
> + ssd130x = ssd130x_probe(&client->dev, regmap);
> +
Redundant blank line.
> + if (IS_ERR(ssd130x)) > + return PTR_ERR(ssd130x);
...
> + { /* sentinel */ },
No comma for terminator entry.
-- With Best Regards, Andy Shevchenko
|