lkml.org 
[lkml]   [2022]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 4/7] drm/solomon: Add SSD130X OLED displays I2C support
On Wed, Feb 09, 2022 at 10:03:11AM +0100, Javier Martinez Canillas wrote:
> The ssd130x driver only provides the core support for these devices but it
> does not have any bus transport logic. Add a driver to interface over I2C.

Thanks!

...

> + * Authors: Javier Martinez Canillas <javierm@redhat.com>

s?!

...

> +#include <linux/i2c.h>
> +#include <linux/module.h>

regmap.h ?
err.h?

...

> + ssd130x = ssd130x_probe(&client->dev, regmap);

> +

Redundant blank line.

> + if (IS_ERR(ssd130x))
> + return PTR_ERR(ssd130x);

...

> + { /* sentinel */ },

No comma for terminator entry.


--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2022-02-09 16:17    [W:0.652 / U:0.788 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site