lkml.org 
[lkml]   [2022]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v3 4/7] drm/solomon: Add SSD130X OLED displays I2C support
    Hi Javier,

    On Wed, Feb 9, 2022 at 10:03 AM Javier Martinez Canillas
    <javierm@redhat.com> wrote:
    > The ssd130x driver only provides the core support for these devices but it
    > does not have any bus transport logic. Add a driver to interface over I2C.
    >
    > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>

    Thanks for your patch!

    > --- /dev/null
    > +++ b/drivers/gpu/drm/solomon/ssd130x-i2c.c

    > +static const struct of_device_id ssd130x_of_match[] = {
    > + {
    > + .compatible = "solomon,ssd1305fb-i2c",
    > + .data = (void *)&ssd130x_ssd1305_deviceinfo,

    The casts are not needed.

    > + },
    > + {
    > + .compatible = "solomon,ssd1306fb-i2c",
    > + .data = (void *)&ssd130x_ssd1306_deviceinfo,
    > + },
    > + {
    > + .compatible = "solomon,ssd1307fb-i2c",
    > + .data = (void *)&ssd130x_ssd1307_deviceinfo,
    > + },
    > + {
    > + .compatible = "solomon,ssd1309fb-i2c",
    > + .data = (void *)&ssd130x_ssd1309_deviceinfo,
    > + },
    > + { /* sentinel */ },
    > +};
    > +MODULE_DEVICE_TABLE(of, ssd130x_of_match);

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    \
     
     \ /
      Last update: 2022-02-09 13:23    [W:4.154 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site