Messages in this thread | | | Date | Tue, 8 Feb 2022 21:47:41 -0600 | From | Rob Herring <> | Subject | Re: [PATCH net-next v1 2/4] dt-bindings: net: add schema for Microchip/SMSC LAN95xx USB Ethernet controllers |
| |
On Thu, Jan 27, 2022 at 11:59:11AM +0100, Greg KH wrote: > On Thu, Jan 27, 2022 at 11:49:03AM +0100, Oleksij Rempel wrote: > > Create initial schema for Microchip/SMSC LAN95xx USB Ethernet controllers and > > import all currently supported USB IDs form drivers/net/usb/smsc95xx.c > > That is a loosing game to play. There is a reason that kernel drivers > only require a device id in 1 place, instead of multiple places like > other operating systems. Please do not go back and make the same > mistakes others have.
This instance doesn't look so bad because SMSC devices are chips rather than random OEM rebranded devices all with the same underlying chip.
> Not to mention that I think overall this is a bad idea anyway. USB > devices are self-describing, don't add them to DT.
Until they are soldered down and the board maker cheaps out on having an eeprom to hold the MAC address...
Rob
| |