Messages in this thread | | | Date | Thu, 27 Jan 2022 12:28:51 +0100 | From | Oleksij Rempel <> | Subject | Re: [PATCH net-next v1 2/4] dt-bindings: net: add schema for Microchip/SMSC LAN95xx USB Ethernet controllers |
| |
On Thu, Jan 27, 2022 at 11:59:11AM +0100, Greg KH wrote: > On Thu, Jan 27, 2022 at 11:49:03AM +0100, Oleksij Rempel wrote: > > Create initial schema for Microchip/SMSC LAN95xx USB Ethernet controllers and > > import all currently supported USB IDs form drivers/net/usb/smsc95xx.c > > That is a loosing game to play. There is a reason that kernel drivers > only require a device id in 1 place, instead of multiple places like > other operating systems. Please do not go back and make the same > mistakes others have. > > Not to mention that I think overall this is a bad idea anyway. USB > devices are self-describing, don't add them to DT.
This patch set is the pre-step before making it even more complicated with description of external PHYs and DSA switches. I assume, it is preferable to have schema to be able to automatically validate it.
Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
| |