Messages in this thread | | | From | John Hubbard <> | Subject | [PATCH v3 0/4] mm/gup: some cleanups | Date | Thu, 3 Feb 2022 01:32:28 -0800 |
| |
Hi Peter, Jason and all,
Changes since v2:
* Patch 2: Removed an unnecessary line that was causing a clang-analyzer complaint, as reported by Lukas Bulwahn [1] (thanks!), and retested locally.
Jason: I've boldly left your Reviewed-by tag on this patch, because I am predicting you'll agree with it...
* Added Reviewed-by tags from Jan Kara, Christoph Hellwig, and Jason Gunthorpe that have collected since v2.
Changes since v1: * Patch 4: changed from get_user_pages(), to get_user_pages_fast().
* Patch 4: Rewrote the commit description--thanks to Jan Kara for that feedback.
* Patch 1: Removed Jerome's Cc from patch 1, due to a stale email address.
* Added Reviewed-by's from David Hildenbrand and Jason Gunthorpe.
Original cover letter, updated as necessary:
I'm including Peter's patch as the first one in this tiny series. (The commit description has my r-b tag in place of my Cc, and removes Jerome's Cc because he is no longer at redhat.com) The second patch is what I had in mind for a follow-up to that, when we were discussing that fix [2].
Plus, a couple more small removals that I had queued up:
The third patch removes a completely unused routine: pin_user_pages_locked().
The forth patch removes a similar routine, get_user_pages_locked(), that only has one caller. It now calls get_user_pages_fast(), instead.
v1 of this patchset is here: https://lore.kernel.org/all/20220131051752.447699-1-jhubbard@nvidia.com/
v2 of this patchset is here: https://lore.kernel.org/r/20220201101108.306062-1-jhubbard@nvidia.com
[1] https://lore.kernel.org/r/CAKXUXMxFK9bo8jDoRZbQ0r2j-JwAGg3Xc5cpAcLaHfwHddJ7ew@mail.gmail.com
[2] https://lore.kernel.org/all/20220125033700.69705-1-peterx@redhat.com/
thanks, John Hubbard
John Hubbard (3): mm/gup: clean up follow_pfn_pte() slightly mm/gup: remove unused pin_user_pages_locked() mm/gup: remove get_user_pages_locked()
Peter Xu (1): mm: Fix invalid page pointer returned with FOLL_PIN gups
include/linux/mm.h | 4 -- mm/gup.c | 99 +++------------------------------------------- mm/mempolicy.c | 21 +++++----- 3 files changed, 15 insertions(+), 109 deletions(-)
base-commit: 88808fbbead481aedb46640a5ace69c58287f56a -- 2.35.1
| |