Messages in this thread Patch in this message | | | From | Miaohe Lin <> | Subject | [PATCH] mm/writeback: minor clean up for highmem_dirtyable_memory | Date | Thu, 24 Feb 2022 19:54:16 +0800 |
| |
Since commit a804552b9a15 ("mm/page-writeback.c: fix dirty_balance_reserve subtraction from dirtyable memory"), local variable x can not be negative values. And it can not overflow when it is the total number of dirtyable highmem pages. Thus remove the unneeded comment and overflow check.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> --- mm/page-writeback.c | 12 ------------ 1 file changed, 12 deletions(-)
diff --git a/mm/page-writeback.c b/mm/page-writeback.c index 48a8cf770e3f..cdba72aa7fa9 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -326,18 +326,6 @@ static unsigned long highmem_dirtyable_memory(unsigned long total) } } - /* - * Unreclaimable memory (kernel memory or anonymous memory - * without swap) can bring down the dirtyable pages below - * the zone's dirty balance reserve and the above calculation - * will underflow. However we still want to add in nodes - * which are below threshold (negative values) to get a more - * accurate calculation but make sure that the total never - * underflows. - */ - if ((long)x < 0) - x = 0; - /* * Make sure that the number of highmem pages is never larger * than the number of the total dirtyable memory. This can only -- 2.23.0
| |