lkml.org 
[lkml]   [2022]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v9 05/10] dt-bindings: clock: Add bindings for SP7021 clock driver
From
On 21/02/2022 04:29, Qin Jian wrote:
> Add documentation to describe Sunplus SP7021 clock driver bindings.
>
> Reviewed-by: Stephen Boyd <sboyd@kernel.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Qin Jian <qinjian@cqplus1.com>
> ---
> .../bindings/clock/sunplus,sp7021-clkc.yaml | 52 ++++++++
> MAINTAINERS | 2 +
> include/dt-bindings/clock/sp-sp7021.h | 112 ++++++++++++++++++
> 3 files changed, 166 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/sunplus,sp7021-clkc.yaml
> create mode 100644 include/dt-bindings/clock/sp-sp7021.h
>
> diff --git a/Documentation/devicetree/bindings/clock/sunplus,sp7021-clkc.yaml b/Documentation/devicetree/bindings/clock/sunplus,sp7021-clkc.yaml
> new file mode 100644
> index 000000000..e6d098cf4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/sunplus,sp7021-clkc.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) Sunplus Co., Ltd. 2021
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/sunplus,sp7021-clkc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sunplus SP7021 SoC Clock Controller Binding
> +
> +maintainers:
> + - Qin Jian <qinjian@cqplus1.com>
> +
> +properties:
> + compatible:
> + const: sunplus,sp7021-clkc
> +
> + "#clock-cells":
> + const: 1
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: External oscillator clock
> + - description: System clock
> +
> + clock-names:
> + items:
> + - const: extclk
> + - const: pllsys
> +
> +required:
> + - compatible
> + - "#clock-cells"
> + - reg
> + - clocks
> + - clock-names
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + clkc: clock-controller@9c000000 {
> + compatible = "sunplus,sp7021-clkc";
> + #clock-cells = <1>;
> + reg = <0x9c000000 0x280>;
> + clocks = <&extclk>, <&clkc PLL_SYS>;

Except the warning pointed out by Rob's bot, it looks like you feed this
clock-controller with a clock from itself. Is there a point to express
it in DTS at all?

> + clock-names = "extclk", "pllsys";
> + };

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-02-23 12:35    [W:0.178 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site