lkml.org 
[lkml]   [2022]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pata_parport: second preview
On Sun, Feb 20, 2022 at 11:49:09PM +0100, Ondrej Zary wrote:
> Protocol registration could be improved - I don't like protocols[] and
> protocol numbers, devices should probably be created by protocol name.
> Also the LPT port base addresses should probably be replaced by port names
> (like parport0).
>
> The bpck driver seems to need to know if a CD drive is attached (weird) but
> I doubt that I can get such info from libata.

You can check adev->class == ATA_DEV_ATAPI, there's a bunch of drivers
that already do that.

I'll try to take a look at the actual patch once I find a bit of time.

\
 
 \ /
  Last update: 2022-02-22 09:36    [W:0.057 / U:0.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site