Messages in this thread | | | Date | Tue, 22 Feb 2022 09:35:25 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH] pata_parport: second preview |
| |
On Sun, Feb 20, 2022 at 11:49:09PM +0100, Ondrej Zary wrote: > Protocol registration could be improved - I don't like protocols[] and > protocol numbers, devices should probably be created by protocol name. > Also the LPT port base addresses should probably be replaced by port names > (like parport0). > > The bpck driver seems to need to know if a CD drive is attached (weird) but > I doubt that I can get such info from libata.
You can check adev->class == ATA_DEV_ATAPI, there's a bunch of drivers that already do that.
I'll try to take a look at the actual patch once I find a bit of time.
| |