lkml.org 
[lkml]   [2022]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v6 01/13] module: Move all into module/
Date


Le 18/02/2022 à 22:24, Aaron Tomlin a écrit :
> No functional changes.
>
> This patch moves all module related code into a separate directory,
> modifies each file name and creates a new Makefile. Note: this effort
> is in preparation to refactor core module code.
>
> Signed-off-by: Aaron Tomlin <atomlin@redhat.com>
> ---
> MAINTAINERS | 2 +-
> kernel/Makefile | 5 +----
> kernel/module/Makefile | 9 +++++++++
> kernel/{module_decompress.c => module/decompress.c} | 2 +-
> kernel/{module-internal.h => module/internal.h} | 0
> kernel/{module.c => module/main.c} | 2 +-
> kernel/{module_signature.c => module/signature.c} | 0
> kernel/{module_signing.c => module/signing.c} | 2 +-
> 8 files changed, 14 insertions(+), 8 deletions(-)
> create mode 100644 kernel/module/Makefile
> rename kernel/{module_decompress.c => module/decompress.c} (99%)
> rename kernel/{module-internal.h => module/internal.h} (100%)
> rename kernel/{module.c => module/main.c} (99%)
> rename kernel/{module_signature.c => module/signature.c} (100%)
> rename kernel/{module_signing.c => module/signing.c} (97%)
>

I'm wondering whether we should avoid moving module_signature.c and
leave it in kernel/ as this file is used even when CONFIG_MODULES is not
selected, and he is the only one like this.

Keeping it outside of kernel/module/ would allow to conditionaly build
entire kernel/module/ based of CONFIG_MODULES and then avoid all checks
against CONFIG_MODULES which look misleading at times.


Christophe
\
 
 \ /
  Last update: 2022-02-21 19:21    [W:0.088 / U:1.984 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site