Messages in this thread | | | From | Aaron Tomlin <> | Date | Mon, 21 Feb 2022 09:22:09 +0000 | Subject | Re: [PATCH v6 09/13] module: Move kallsyms support into a separate file |
| |
On Mon 2022-02-21 09:35 +0100, Christophe Leroy wrote: > Fixup: > > diff --git a/kernel/module/kallsyms.c b/kernel/module/kallsyms.c > index 6c8f1f390cf5..2ee8d2e67068 100644 > --- a/kernel/module/kallsyms.c > +++ b/kernel/module/kallsyms.c > @@ -171,8 +171,7 @@ void add_kallsyms(struct module *mod, const struct > load_info *info) > Elf_Shdr *symsec = &info->sechdrs[info->index.sym]; > > /* Set up to point into init section. */ > - mod->kallsyms = (struct mod_kallsyms __rcu *)mod->init_layout.base + > - info->mod_kallsyms_init_off; > + mod->kallsyms = (void __rcu *)mod->init_layout.base + > info->mod_kallsyms_init_off; > > /* The following is safe since this pointer cannot change */ > rcu_dereference_sched(mod->kallsyms)->symtab = (void *)symsec->sh_addr;
Agreed.
-- Aaron Tomlin
| |