lkml.org 
[lkml]   [2022]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v6 09/13] module: Move kallsyms support into a separate file
On Mon 2022-02-21 09:35 +0100, Christophe Leroy wrote:
> Fixup:
>
> diff --git a/kernel/module/kallsyms.c b/kernel/module/kallsyms.c
> index 6c8f1f390cf5..2ee8d2e67068 100644
> --- a/kernel/module/kallsyms.c
> +++ b/kernel/module/kallsyms.c
> @@ -171,8 +171,7 @@ void add_kallsyms(struct module *mod, const struct
> load_info *info)
> Elf_Shdr *symsec = &info->sechdrs[info->index.sym];
>
> /* Set up to point into init section. */
> - mod->kallsyms = (struct mod_kallsyms __rcu *)mod->init_layout.base +
> - info->mod_kallsyms_init_off;
> + mod->kallsyms = (void __rcu *)mod->init_layout.base +
> info->mod_kallsyms_init_off;
>
> /* The following is safe since this pointer cannot change */
> rcu_dereference_sched(mod->kallsyms)->symtab = (void *)symsec->sh_addr;

Agreed.

--
Aaron Tomlin

\
 
 \ /
  Last update: 2022-02-21 19:50    [W:0.046 / U:0.940 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site