| Date | Mon, 21 Feb 2022 15:30:56 +0100 | Subject | Re: [PATCH v8 08/19] drm/mediatek: dpi: move dimension mask to board config | From | AngeloGioacchino Del Regno <> |
| |
Il 18/02/22 15:54, Guillaume Ranquet ha scritto: > Add flexibility by moving the dimension mask to the board config >
s/board/SoC/g
> Signed-off-by: Guillaume Ranquet <granquet@baylibre.com> > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 26 ++++++++++++++++---------- > 1 file changed, 16 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c > index 454f8563efae4..8ca3455ed64ee 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c > @@ -127,6 +127,8 @@ struct mtk_dpi_conf { > u32 num_output_fmts; > bool is_ck_de_pol; > bool swap_input_support; > + // Mask used for HWIDTH, HPORCH, VSYNC_WIDTH and VSYNC_PORCH (no shift)
Also, C-style comments, please.
After the change, Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> + u32 dimension_mask; > const struct mtk_dpi_yc_limit *limit; > }; >
|