Messages in this thread Patch in this message | | | Subject | Re: [PATCH] pps: clients: gpio: Propagate return value from pps_gpio_probe | From | Rodolfo Giometti <> | Date | Wed, 2 Feb 2022 18:40:50 +0100 |
| |
On 02/02/22 18:04, Robert Hancock wrote: > On Sun, 2022-01-30 at 10:35 +0100, Rodolfo Giometti wrote: >> On 29/01/22 23:02, Robert Hancock wrote: >>> On Thu, 2022-01-13 at 09:17 +0100, Rodolfo Giometti wrote: >>>> On 12/01/22 22:07, Andy Shevchenko wrote: >>>>> On Wed, Jan 12, 2022 at 02:52:14PM -0600, Robert Hancock wrote: >>>>>> If the pps-gpio driver was probed prior to the GPIO device it uses, >>>>>> the >>>>>> devm_gpiod_get call returned an -EPROBE_DEFER error, but >>>>>> pps_gpio_probe >>>>>> replaced that error code with -EINVAL, causing the pps-gpio probe to >>>>>> fail and not be retried later. Propagate the error return value so >>>>>> that >>>>>> deferred probe works properly. >>>>> >>>>> FWIW, >>>>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >>>> >>>> Acked-by: Rodolfo Giometti <giometti@enneenne.com> >>> >>> It's not entirely clear to me what tree PPS patches are supposed to go >>> through. >>> Seems like some recent ones have gone through char-misc? Not sure if >>> someone >>> has this in their queue? >> >> LinuxPPS has no its own tree. All related patches usually are sent to me to >> be >> acked and to Greg Kroah-Hartman for inclusion. >> >> Ciao, >> >> Rodolfo >> > > It looks like some MAINTAINERS links should maybe be updated for PPS - the > referenced page at http://wiki.enneenne.com/index.php/LinuxPPS_support seems to > be dead. There is http://linuxpps.org/doku.php which points to a new mailing > list location as well,
Yeah. Attached is a patch to fix these.
> but that seems to have very little activity.
That's one of reasons why LunuxPPS doesn't have its own tree. :)
Ciao,
Rodolfo
-- GNU/Linux Solutions e-mail: giometti@enneenne.com Linux Device Driver giometti@linux.it Embedded Systems phone: +39 349 2432127 UNIX programming skype: rodolfo.giometti From ab95f9b0dcbd538eb43e09eb358c782404ddf024 Mon Sep 17 00:00:00 2001 From: Rodolfo Giometti <giometti@enneenne.com> Date: Wed, 2 Feb 2022 18:37:20 +0100 Subject: [PATCH] MAINTAINERS: update LinuxPPS's resources
Signed-off-by: Rodolfo Giometti <giometti@enneenne.com> --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS index f41088418aae..9176ba3093b7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -15490,9 +15490,9 @@ F: drivers/net/ppp/ppp_* PPS SUPPORT M: Rodolfo Giometti <giometti@enneenne.com> -L: linuxpps@ml.enneenne.com (subscribers-only) +L: discussions@linuxpps.org (subscribers-only) S: Maintained -W: http://wiki.enneenne.com/index.php/LinuxPPS_support +W: http://linuxpps.org/doku.php F: Documentation/ABI/testing/sysfs-pps F: Documentation/devicetree/bindings/pps/pps-gpio.txt F: Documentation/driver-api/pps.rst -- 2.25.1
| |