Messages in this thread | | | From | Robert Hancock <> | Subject | Re: [PATCH] pps: clients: gpio: Propagate return value from pps_gpio_probe | Date | Wed, 2 Feb 2022 17:04:13 +0000 |
| |
On Sun, 2022-01-30 at 10:35 +0100, Rodolfo Giometti wrote: > On 29/01/22 23:02, Robert Hancock wrote: > > On Thu, 2022-01-13 at 09:17 +0100, Rodolfo Giometti wrote: > > > On 12/01/22 22:07, Andy Shevchenko wrote: > > > > On Wed, Jan 12, 2022 at 02:52:14PM -0600, Robert Hancock wrote: > > > > > If the pps-gpio driver was probed prior to the GPIO device it uses, > > > > > the > > > > > devm_gpiod_get call returned an -EPROBE_DEFER error, but > > > > > pps_gpio_probe > > > > > replaced that error code with -EINVAL, causing the pps-gpio probe to > > > > > fail and not be retried later. Propagate the error return value so > > > > > that > > > > > deferred probe works properly. > > > > > > > > FWIW, > > > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > > > Acked-by: Rodolfo Giometti <giometti@enneenne.com> > > > > It's not entirely clear to me what tree PPS patches are supposed to go > > through. > > Seems like some recent ones have gone through char-misc? Not sure if > > someone > > has this in their queue? > > LinuxPPS has no its own tree. All related patches usually are sent to me to > be > acked and to Greg Kroah-Hartman for inclusion. > > Ciao, > > Rodolfo >
It looks like some MAINTAINERS links should maybe be updated for PPS - the referenced page at http://wiki.enneenne.com/index.php/LinuxPPS_support seems to be dead. There is http://linuxpps.org/doku.php which points to a new mailing list location as well, but that seems to have very little activity.
Greg, can you pick this patch ( https://lkml.org/lkml/2022/1/12/879 ) up?
-- Robert Hancock Senior Hardware Designer, Calian Advanced Technologies www.calian.com
| |