Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [PATCHv2 03/29] x86/tdx: Add __tdx_module_call() and __tdx_hypercall() helper functions | Date | Wed, 02 Feb 2022 18:08:11 +0100 |
| |
Kirill,
On Wed, Feb 02 2022 at 05:55, Kirill A. Shutemov wrote: > On Tue, Feb 01, 2022 at 08:58:59PM +0100, Thomas Gleixner wrote: > Okay, below is my take on addressing feedback for both __tdx_module_call() > and __tdx_hypercall(). > > It is fixup for whole patchset. It has to be folded accordingly. I wanted > to check if it works and see if I understand your request correctly. > > __tdx_module_call() is now implemented by including tdxcall.S can using > the macro defined there. Host side of TDX can do the same on their side. > TDX_MODULE_* offsets are now outside of CONFIG_INTEL_TDX_GUEST and can be > used by both host can guest. > > I changed __tdx_hypercall() to take single argument with struct pointer > that used for both input and output. > > Is it the right direction? Or did I misunderstand something?
Looks good. Nice consolidation and I like the idea of using one structure for in and out.
Thanks,
tglx
| |