| Date | Wed, 2 Feb 2022 14:51:56 -0800 | From | Matthias Kaehlcke <> | Subject | Re: [PATCH v3 07/14] arm64: dts: qcom: sc7280: Add edp_out port and HPD lines |
| |
On Wed, Feb 02, 2022 at 01:23:41PM -0800, Douglas Anderson wrote: > Like dp_out, we should have defined edp_out in sc7280.dtsi so we don't > need to do this in the board files. > > Like dp_hot_plug_det, we should define edp_hot_plug_det in > sc7280.dtsi. > > We should set the default pinctrl for edp_hot_plug_det in > sc7280.dtsi. NOTE: this is _unlike_ the dp_hot_plug_det. It is > reasonable that in some boards the dedicated DP Hot Plug Detect will > not be hooked up in favor of Type C mechanisms. This is unlike eDP > where the Hot Plug Detect line (which functions as "panel ready" in > eDP) is highly likely to be used by boards. > > Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
|