Messages in this thread | | | From | Doug Anderson <> | Date | Fri, 4 Feb 2022 14:14:58 -0800 | Subject | Re: [PATCH v3 12/14] arm64: dts: qcom: sc7280: Add herobrine-r1 |
| |
Hi,
On Thu, Feb 3, 2022 at 3:26 PM Doug Anderson <dianders@chromium.org> wrote: > > Hi, > > On Wed, Feb 2, 2022 at 1:24 PM Douglas Anderson <dianders@chromium.org> wrote: > > > > +&pcie1_clkreq_n { > > + bias-disable; > > + drive-strength = <2>; > > +}; > > As per the discussion [1] then maybe the above should be > `bias-pull-up` instead of `bias-disable`. I'm happy to spin this, have > it fixed by the maintainer when applied, or do a follow-up patch to > fix this. Please let me know.
Breadcrumbs: since most of this series landed but not this patch, I've sent a new version with the fixup.
https://lore.kernel.org/r/20220204140550.v4.1.I5604b7af908e8bbe709ac037a6a8a6ba8a2bfa94@changeid/
| |