Messages in this thread | | | Date | Sat, 19 Feb 2022 15:58:51 -0800 | From | Kees Cook <> | Subject | Re: [PATCH] slab: remove __alloc_size attribute from __kmalloc_track_caller |
| |
On Fri, Feb 18, 2022 at 09:19:51AM -0800, Nick Desaulniers wrote: > On Fri, Feb 18, 2022 at 5:14 AM Greg Kroah-Hartman > <gregkh@linuxfoundation.org> wrote: > > > > Commit c37495d6254c ("slab: add __alloc_size attributes for better > > bounds checking") added __alloc_size attributes to a bunch of kmalloc > > function prototypes. Unfortunately the change to __kmalloc_track_caller > > seems to cause clang to generate broken code and the first time this is > > called when booting, the box will crash. > > > > While the compiler problems are being reworked and attempted to be > > solved, let's just drop the attribute to solve the issue now. Once it > > is resolved it can be added back. > > Sorry about the mess; we'll get it cleaned up! > Acked-by: Nick Desaulniers <ndesaulniers@google.com> > Link: https://github.com/ClangBuiltLinux/linux/issues/1599
Thanks for the issue link!
Acked-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
| |