Messages in this thread | | | Date | Fri, 18 Feb 2022 10:47:30 -0800 (PST) | From | David Rientjes <> | Subject | Re: [PATCH] slab: remove __alloc_size attribute from __kmalloc_track_caller |
| |
On Fri, 18 Feb 2022, Greg Kroah-Hartman wrote:
> Commit c37495d6254c ("slab: add __alloc_size attributes for better > bounds checking") added __alloc_size attributes to a bunch of kmalloc > function prototypes. Unfortunately the change to __kmalloc_track_caller > seems to cause clang to generate broken code and the first time this is > called when booting, the box will crash. > > While the compiler problems are being reworked and attempted to be > solved, let's just drop the attribute to solve the issue now. Once it > is resolved it can be added back. > > Fixes: c37495d6254c ("slab: add __alloc_size attributes for better bounds checking") > Cc: stable <stable@vger.kernel.org> > Cc: Kees Cook <keescook@chromium.org> > Cc: Daniel Micay <danielmicay@gmail.com> > Cc: Nick Desaulniers <ndesaulniers@google.com> > Cc: Christoph Lameter <cl@linux.com> > Cc: Pekka Enberg <penberg@kernel.org> > Cc: David Rientjes <rientjes@google.com> > Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Vlastimil Babka <vbabka@suse.cz> > Cc: Nathan Chancellor <nathan@kernel.org> > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Cc: llvm@lists.linux.dev > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: David Rientjes <rientjes@google.com>
| |