lkml.org 
[lkml]   [2022]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/11] KVM: x86: Treat x2APIC's ICR as a 64-bit register, not two 32-bit regs
> 	case APIC_SELF_IPI:
>- if (apic_x2apic_mode(apic)) {
>- kvm_lapic_reg_write(apic, APIC_ICR,
>- APIC_DEST_SELF | (val & APIC_VECTOR_MASK));
>- } else
>+ if (apic_x2apic_mode(apic))
>+ kvm_x2apic_icr_write(apic, APIC_DEST_SELF | (val & APIC_VECTOR_MASK));
>+ else

The original code looks incorrect. Emulating writes to SELF_IPI by writes to
ICR has an unwanted side-effect: the value of ICR in vAPIC page gets changed.

It is better to use kvm_apic_send_ipi() directly.

\
 
 \ /
  Last update: 2022-02-15 04:17    [W:0.121 / U:1.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site