lkml.org 
[lkml]   [2022]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 04/11] KVM: SVM: Use common kvm_apic_write_nodecode() for AVIC write traps
On Sat, Feb 05, 2022, kernel test robot wrote:
> All errors (new ones prefixed by >>):
>
> arch/x86/kvm/svm/avic.c: In function 'avic_unaccel_trap_write':
> >> arch/x86/kvm/svm/avic.c:486:35: error: 'svm' undeclared (first use in this function); did you mean 'sem'?
> 486 | if (avic_handle_apic_id_update(&svm->vcpu))
> | ^~~
> | sem
> arch/x86/kvm/svm/avic.c:486:35: note: each undeclared identifier is reported only once for each function it appears in
>
>
> vim +486 arch/x86/kvm/svm/avic.c
>
> ef0f64960d012cb Joerg Roedel 2020-03-31 478
> 528172fca9c0e8f Sean Christopherson 2022-02-04 479 static int avic_unaccel_trap_write(struct kvm_vcpu *vcpu)
> ef0f64960d012cb Joerg Roedel 2020-03-31 480 {
> 528172fca9c0e8f Sean Christopherson 2022-02-04 481 u32 offset = to_svm(vcpu)->vmcb->control.exit_info_1 &
> ef0f64960d012cb Joerg Roedel 2020-03-31 482 AVIC_UNACCEL_ACCESS_OFFSET_MASK;
> ef0f64960d012cb Joerg Roedel 2020-03-31 483
> ef0f64960d012cb Joerg Roedel 2020-03-31 484 switch (offset) {
> ef0f64960d012cb Joerg Roedel 2020-03-31 485 case APIC_ID:
> ef0f64960d012cb Joerg Roedel 2020-03-31 @486 if (avic_handle_apic_id_update(&svm->vcpu))
> ef0f64960d012cb Joerg Roedel 2020-03-31 487 return 0;

Doh, I did all my testing with avic_handle_apic_id_update() completely removed
(because it's broken), but obviously forgot to rebuild without that patch when
posting.

\
 
 \ /
  Last update: 2022-02-07 17:33    [W:2.177 / U:1.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site