Messages in this thread | | | Date | Wed, 7 Dec 2022 16:56:11 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH v14 3/7] crash: add generic infrastructure for crash hotplug support |
| |
On Wed, Dec 07, 2022 at 09:57:48PM +0800, Baoquan He wrote: > I thought we usually need to introduce the kernel config option, then > add code related to it, so that is a wrong idea.
It depends: sometimes it is prudent to add the code behind an ifdeffery first but have it not being buildable so that you don't have to deal with build breakages but rather concentrate on adding the facilities first.
And you add the Kconfig item only in the end where everything is in place and it should build properly then.
> It would be helpful to tell this somewhere in document.
Feel free. I mean, it is pretty obvious but if it helps, it wouldn't hurt.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |