Messages in this thread | | | Date | Thu, 8 Dec 2022 12:03:19 +0800 | From | Baoquan He <> | Subject | Re: [PATCH v14 3/7] crash: add generic infrastructure for crash hotplug support |
| |
On 12/07/22 at 04:56pm, Borislav Petkov wrote: > On Wed, Dec 07, 2022 at 09:57:48PM +0800, Baoquan He wrote: > > I thought we usually need to introduce the kernel config option, then > > add code related to it, so that is a wrong idea. > > It depends: sometimes it is prudent to add the code behind an ifdeffery > first but have it not being buildable so that you don't have to deal > with build breakages but rather concentrate on adding the facilities > first. > > And you add the Kconfig item only in the end where everything is in > place and it should build properly then.
I see. Now it's pretty clear to us. Thanks a lot.
> > > It would be helpful to tell this somewhere in document. > > Feel free. I mean, it is pretty obvious but if it helps, it wouldn't hurt.
OK, at least people tracking this thread got this now.
| |