Messages in this thread | | | Date | Wed, 7 Dec 2022 13:36:03 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v7 tty-next 1/4] serial: 8250_pci: Add serial8250_pci_setup_port definition in 8250_pcilib.c |
| |
On Thu, Dec 08, 2022 at 05:23:02AM +0530, Kumaravel Thiagarajan wrote: > Move implementation of setup_port func() to serial8250_pci_setup_port. > > Co-developed-by: Tharun Kumar P <tharunkumar.pasumarthi@microchip.com> > Signed-off-by: Tharun Kumar P <tharunkumar.pasumarthi@microchip.com> > Signed-off-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com> > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
(One nit-pick below, though)
...
> config SERIAL_8250_PCI > tristate "8250/16550 PCI device support" > depends on SERIAL_8250 && PCI > + select SERIAL_8250_PCILIB > default SERIAL_8250 > help > This builds standard PCI serial support. You may be able to > @@ -500,6 +501,9 @@ config SERIAL_8250_MID > Intel Medfield SOC and various other Intel platforms that is not > covered by the more generic SERIAL_8250_PCI option. > > +config SERIAL_8250_PCILIB > + bool > +
Not sure why it's here and not just above 8250_PCI, but it's minor thing.
> tristate "Support for Pericom and Acces I/O serial ports" > default SERIAL_8250
-- With Best Regards, Andy Shevchenko
| |