lkml.org 
[lkml]   [2022]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v7 tty-next 2/4] serial: 8250_pci1xxxx: Add driver for quad-uart support
Date
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Thursday, December 8, 2022 1:31 AM
> To: Kumaravel Thiagarajan - I21417
> <Kumaravel.Thiagarajan@microchip.com>
> Subject: Re: [PATCH v7 tty-next 2/4] serial: 8250_pci1xxxx: Add driver for
> quad-uart support
>
> > + priv->membase = pcim_iomap(pdev, 0, 0);
>
> Is any of those card can have an IO bar (instead of MEM)?

No Andy

> > + if (num_vectors == 4)
> > + writeb(UART_PCI_CTRL_SET_MULTIPLE_MSI,
> > + priv->membase + UART_PCI_CTRL_REG);
>
> If you set this unconditionally when num_vectors < 4, would it still work?

UART_PCI_CTRL_SET_MULTIPLE_MSI must be set only when all the requested interrupt vectors
are allocated by the pci_alloc_irq_vectors API. Number of interrupt vectors requested was always
4 previously and that logic will be modified to request only which is required in V8 patch.


Thanks,
Tharun Kumar P

\
 
 \ /
  Last update: 2022-12-10 12:20    [W:0.055 / U:1.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site