Messages in this thread | | | From | Badhri Jagan Sridharan <> | Date | Mon, 5 Dec 2022 17:33:15 -0800 | Subject | Re: [PATCH v3 3/3] usb: typec: maxim_contaminant: Implement check_contaminant callback |
| |
Fixing both the comments in version 4 of the patchset. Thanks !
On Sun, Dec 4, 2022 at 7:57 AM Guenter Roeck <linux@roeck-us.net> wrote: > > On Sun, Dec 04, 2022 at 10:43:02AM +0100, Greg Kroah-Hartman wrote: > > On Sun, Dec 04, 2022 at 12:48:44AM -0800, Badhri Jagan Sridharan wrote: > > > +EXPORT_SYMBOL_GPL(is_contaminant); > > > > Sorry, but this is a horrible name for the kernel global namespace. > > Please properly prefix it to show exactly what subsystem this is from. > > > > I don't think this needs to be exported either. > > Guenter
| |