lkml.org 
[lkml]   [2022]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 3/3] usb: typec: maxim_contaminant: Implement check_contaminant callback
On Sun, Dec 04, 2022 at 10:43:02AM +0100, Greg Kroah-Hartman wrote:
> On Sun, Dec 04, 2022 at 12:48:44AM -0800, Badhri Jagan Sridharan wrote:
> > +EXPORT_SYMBOL_GPL(is_contaminant);
>
> Sorry, but this is a horrible name for the kernel global namespace.
> Please properly prefix it to show exactly what subsystem this is from.
>

I don't think this needs to be exported either.

Guenter

\
 
 \ /
  Last update: 2022-12-04 16:57    [W:0.058 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site