Messages in this thread Patch in this message |  | | From | Kemeng Shi <> | Subject | [PATCH v3 7/9] blk-throttle: remove incorrect comment for tg_last_low_overflow_time | Date | Mon, 5 Dec 2022 19:57:07 +0800 |
| |
From: Kemeng Shi <shikemeng@huawei.com>
Function tg_last_low_overflow_time is called with intermediate node as following: throtl_hierarchy_can_downgrade throtl_tg_can_downgrade tg_last_low_overflow_time
throtl_hierarchy_can_upgrade throtl_tg_can_upgrade tg_last_low_overflow_time
throtl_hierarchy_can_downgrade/throtl_hierarchy_can_upgrade will traverse from leaf node to sub-root node and pass traversed intermediate node to tg_last_low_overflow_time.
No such limit could be found from context and implementation of tg_last_low_overflow_time, so remove this limit in comment.
Signed-off-by: Kemeng Shi <shikemeng@huawei.com> Acked-by: Tejun Heo <tj@kernel.org> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> --- block/blk-throttle.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/block/blk-throttle.c b/block/blk-throttle.c index 7db8592dae38..e6a087de414d 100644 --- a/block/blk-throttle.c +++ b/block/blk-throttle.c @@ -1762,7 +1762,6 @@ static unsigned long __tg_last_low_overflow_time(struct throtl_grp *tg) return min(rtime, wtime); } -/* tg should not be an intermediate node */ static unsigned long tg_last_low_overflow_time(struct throtl_grp *tg) { struct throtl_service_queue *parent_sq; -- 2.30.0
|  |