Messages in this thread | | | Subject | Re: [PATCH v3 1/9] blk-throttle: correct stale comment in throtl_pd_init | From | Kemeng Shi <> | Date | Tue, 6 Dec 2022 09:17:58 +0800 |
| |
on 12/6/2022 4:43 AM, Jens Axboe wrote: > On 12/5/22 4:57?AM, Kemeng Shi wrote: >> From: Kemeng Shi <shikemeng@huawei.com> >> >> On the default hierarchy (cgroup2), the throttle interface files don't >> exist in the root cgroup, so the ablity to limit the whole system >> by configuring root group is not existing anymore. In general, cgroup >> doesn't wanna be in the business of restricting resources at the >> system level, so correct the stale comment that we can limit whole >> system to we can only limit subtree. >> >> Signed-off-by: Kemeng Shi <shikemeng@huawei.com> >> Acked-by: Tejun Heo <tj@kernel.org> >> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> > > Which one should be used? You have duplicate SOBs in each of the > commits. It's marked as being from Kemeng Shi <shikemeng@huawei.com> so > that is what I'll use.
Either one is great, thanks.
-- Best wishes Kemeng Shi
| |