lkml.org 
[lkml]   [2022]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] trace: Fix some checker warnings
On Mon, 5 Dec 2022 12:29:48 +0900
Masami Hiramatsu (Google) <mhiramat@kernel.org> wrote:

> No, that including defined(CONFIG_FSNOTIFY) :)

Ah I missed that :-)

>
> So it must be something like
>
> #if defined(CONFIG_TRACER_MAX_TRACE) || defined(CONFIG_HWLAT_TRACER) \
> || defined(CONFIG_OSNOISE_TRACER)
> #define USE_MAX_TRACE_OPS
> #endif
>
> #if defined(USE_MAX_TRACE_OPS) && defined(CONFIG_FSNOTIFY)
> #define LATENCY_FS_NOTIFY
> #endif
>
>
> But this introduces a hidden dependency which is not tracked by
> kconfig. So I think it is better to make those kconfig (non-menu)

Right, that could be done.

> items. (and the question came up, why can't those use (depend on)
> CONFIG_TRACER_MAX_TRACE instead of introducing the USE_MAX_TRACE_OPS.)

Probably just have OSNOISE and HWLAT select TRACER_MAX_TRACE and just
use that.

-- Steve

\
 
 \ /
  Last update: 2022-12-05 04:34    [W:0.047 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site